Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dump_genesis command in cli #511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dump_genesis command in cli #511

wants to merge 1 commit into from

Conversation

Jeongseup
Copy link
Contributor

I think that it is useful to make dummy genesis files which will be used in dev or easy start

junha1
junha1 reviewed Aug 29, 2023
View reviewed changes
cli/src/cli.rs
@@ -76,6 +76,8 @@ pub enum SignCommands {

#[derive(Debug, Subcommand)]
pub enum Commands {
/// Dumps genesis block files to the path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy? Dump? Please match the word

simperby/src/lib.rs
.await
.unwrap();

let keys = serde_spb::to_string(&keys)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary newlines here

@Jeongseup
Copy link
Contributor Author

Could you please review again? I modified as what you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junha1 junha1 junha1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeongseup @junha1